Move minimum supported rust version (MSRV) from 1.65 back to 1.64. #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following error variants were large enough to trip Clippy's `result_large_err` lint: - RenderPassCompatibilityError::IncompatibleColorAttachment - CreateShaderModuleError::Validation Large error types are a problem, because they make the `Result` type large, requiring the program to copy around large numbers of bytes even in the success case. Since the failure case is rare, it's usually not a problem to just heap-allocate the contents to keep the `Ok` case small.
jimblandy
force-pushed
the
revert-to-rust-1.64
branch
from
4e8abe7 to
c7297cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #3231 +/- ##
==========================================
- Coverage 64.70% 64.62% -0.09%
==========================================
Files 81 81
Lines 38819 39479 +660
==========================================
+ Hits 25118 25512 +394
- Misses 13701 13967 +266
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cwfitzgerald
requested changes
Nov 23, 2022
jimblandy
force-pushed
the
revert-to-rust-1.64
branch
from
c7297cf to
fed5dc9
Compare
cwfitzgerald
approved these changes
Nov 23, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.