Force all adapters to report min buffer alignment of 32 #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Dec 5, 2022
Codecov Report
@@ Coverage Diff @@
## master #3262 +/- ##
==========================================
+ Coverage 64.11% 64.14% +0.03%
==========================================
Files 86 86
Lines 42560 42572 +12
==========================================
+ Hits 27286 27308 +22
+ Misses 15274 15264 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…t/min_storage_buffer_offset_alignment of at least 32
Wumpf
force-pushed
the
fix-buffer-alignments-lower-than-32
branch
from
221f32f to
b787007
Compare
|
@cwfitzgerald apologies for the hiatus! |
|
Merge conflicts |
…ents-lower-than-32
|
resolved |
nical
reviewed
Dec 21, 2022
Wumpf
force-pushed
the
fix-buffer-alignments-lower-than-32
branch
from
2de272b to
8e5a635
Compare
cwfitzgerald
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Description
This follows up on the WebGPU spec which doesn't allow an api to report less than 32 bytes buffer alignment.
(brought up on Matrix https://matrix.to/#/!XFRnMvAfptAHthwBCx:matrix.org/$YbQEfpuY-nNlZWNGexna4w0pHa_ItGlm0oHlPvrC5Ds?via=matrix.org&via=mozilla.org&via=kyju.org)
Testing
Ran some sample applications with this