Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ObjectId structure and invariants idiomatic #3347

Merged
merged 3 commits into from
Jan 4, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Jan 4, 2023

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

Description

  • disable the expose-ids feature by default (also fix compilation errors)
  • make ObjectId structure and invariants idiomatic
  • fix global_id always being 0 with the direct backend

Testing

@teoxoy teoxoy force-pushed the ObjectId-improvements branch from 7b7921a to 275d7ac Compare January 4, 2023 14:53
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #3347 (51058a3) into master (71f5040) will increase coverage by 0.08%.
The diff coverage is 76.92%.

❗ Current head 51058a3 differs from pull request most recent head deb0a13. Consider uploading reports for the commit deb0a13 to get more accurate results

@@            Coverage Diff             @@
##           master    #3347      +/-   ##
==========================================
+ Coverage   64.43%   64.51%   +0.08%     
==========================================
  Files          86       86              
  Lines       42638    42597      -41     
==========================================
+ Hits        27473    27481       +8     
+ Misses      15165    15116      -49     
Impacted Files Coverage Δ
wgpu-core/src/id.rs 84.84% <ø> (+2.49%) ⬆️
wgpu/src/lib.rs 52.58% <ø> (+1.35%) ⬆️
wgpu/src/context.rs 53.32% <66.66%> (+0.04%) ⬆️
wgpu/src/backend/direct.rs 56.87% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@teoxoy teoxoy force-pushed the ObjectId-improvements branch from 275d7ac to 51058a3 Compare January 4, 2023 16:28
@teoxoy teoxoy force-pushed the ObjectId-improvements branch from 51058a3 to 3b67270 Compare January 4, 2023 16:32
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup - could probably use a test, but that doesn't need to be in this PR

@cwfitzgerald cwfitzgerald merged commit 784ee43 into gfx-rs:master Jan 4, 2023
@teoxoy teoxoy deleted the ObjectId-improvements branch January 4, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants