Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vk: improve view_formats setting #3412

Merged
merged 6 commits into from
Jan 23, 2023
Merged

Conversation

jinleili
Copy link
Contributor

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.

Connections
Follow up to #3237

Description
More efficient view_formats support is described in the VK_KHR_image_format_list extension

Testing
Only tested via --features=vulkan-portability

Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Left a few comments, looks good otherwise.

wgpu-core/src/device/mod.rs Outdated Show resolved Hide resolved
wgpu-hal/src/vulkan/device.rs Outdated Show resolved Hide resolved
wgpu-hal/src/vulkan/device.rs Outdated Show resolved Hide resolved
@teoxoy teoxoy merged commit 4cd753b into gfx-rs:master Jan 23, 2023
@jinleili jinleili deleted the vk_view_formats branch January 24, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants