-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve vk format msaa capabilities detection #3429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
requested changes
Jan 27, 2023
jinleili
added a commit
to jinleili/wgpu-in-app
that referenced
this pull request
Jan 28, 2023
teoxoy
reviewed
Jan 28, 2023
Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>
teoxoy
approved these changes
Jan 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
cwfitzgerald
added
the
PR: needs back-porting
PR with a fix that needs to land on crates
label
Feb 1, 2023
cwfitzgerald
pushed a commit
that referenced
this pull request
Feb 9, 2023
* Improve vk format msaa capabilities detection * Update CHANGELOG * Follow the suggestions * Update wgpu-hal/src/vulkan/adapter.rs Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>
cwfitzgerald
removed
the
PR: needs back-porting
PR with a fix that needs to land on crates
label
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Description
MSAA with a sample count greater than 1 (e.g., 4) will result in the following validation error on the vk backend:
Here are the relevant fields defined in vk Limits:
On my test devices,
storageImageSampleCounts
always equal toSampleCountFlags::TYPE_1
.Testing
Tested on Android 13 and macOS (--features=vulkan-portability) via wgpu-in-app