Fix definition of NSOperatingSystemVersion
#3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `NSOperatingSystemVersion` struct doesn't contain an `is_mac` flag, so the cast in `msg_send![process_info, operatingSystemVersion]` is invalid.
|
Tested on M1 Mac and everything works fine. But strangely I can't reproduce the issue in #3556, the |
|
@jinleili thank you for testing this change! The extra |
cwfitzgerald
approved these changes
Mar 6, 2023
cwfitzgerald
added
the
PR: needs back-porting
cwfitzgerald
pushed a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Mar 9, 2023
cwfitzgerald
pushed a commit
that referenced
this pull request
Mar 9, 2023
cwfitzgerald
removed
the
PR: needs back-porting
xiaopengli89
added a commit
to xiaopengli89/wgpu
that referenced
this pull request
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Fixes #3556
Description
The
NSOperatingSystemVersionstruct is defined by Apple and doesn't contain anis_macflag, so the existing cast inmsg_send![process_info, operatingSystemVersion]is invalid.Testing
Untested