Roll libloading back to 0.7 to avoid windows-rs dep. #3708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libloading switched from winapi to windows-rs in 0.8, making wgpu unconditionally depend on windows-rs. Unfortunately mozilla is still not ready to take that dependency. This commit rolls back to the previous libloading version so that the windows-rs dep remains optional.
|
This PR only partially reverts the version bump. I opened #3709 since it was easy enough to do through github's revert button on merged PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Dependabot updated libloading to 0.8 in 7f179ff
Description
Libloading switched from winapi to windows-rs in 0.8, making wgpu unconditionally depend on windows-rs. Unfortunately mozilla is still not ready to take that dependency. This commit rolls back to the previous libloading version so that the windows-rs dep remains optional.