Pass correct surface for existing canvases #3718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gents83
added a commit
to gents83/wgpu
that referenced
this pull request
Apr 30, 2023
Pass correct surface for existing canvases (gfx-rs#3718)
cwfitzgerald
added
the
PR: needs back-porting
Wumpf
pushed a commit
to rerun-io/wgpu
that referenced
this pull request
May 14, 2023
cwfitzgerald
pushed a commit
that referenced
this pull request
May 25, 2023
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Fixes #3710
Description
We were passing the
(id, data)tuple instead ofdatawhich was expected. This was hard to spot because we useAnyfor surface types, so it eventually results in adowncast_refmuch later. We should try to improve type safety here after we figure out howArcwill be integrated with the WebGPU backend.Testing
Tested by modifying hello-triangle to create the surface from a canvas instead of a handle.