-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash on command buffer drop #3726
Conversation
Wrong object was passed for `data` to `command_buffer_drop`
@emilk I agree with the two comments, but I intentionally sticked with the pattern of the other drop implementations in this file to make it less confusing. If there is no data object but an id we are in an invalid state and should not continue either, so we need to handle this error in some way. |
de497ae
to
df51aa4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Fixes #3724
Description
Oversight in: #3657
Passed the wrong object was passed for
data
tocommand_buffer_drop
, causing type conversion assertion to fail at runtime 😱Testing
Add minimal repro
to hello triangle. Before:
thread 'main' panicked at 'assertion failed: data.is::<T>()', wgpu/src/context.rs:1045:5