Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove obsolete wasm-pack workaround #3728

Closed
wants to merge 2 commits into from

Conversation

haraldreingruber
Copy link
Contributor

@haraldreingruber haraldreingruber commented Apr 25, 2023

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
This is a follow-up of #3238

Description
Workspace inheritance is supported by wasm-pack v0.11, so the workaround added in #3238 - which installs a branch version - isn't necessary anymore. Now the released wasm-pack binary can be installed directly.

Testing
The test job would fail if wasm-pack wouldn't be correctly installed.

Workspace inheritance is supported by wasm-pack v0.11, so the workaround which installs a branch version isn't necessary anymore.
@haraldreingruber haraldreingruber marked this pull request as ready for review April 25, 2023 20:34
@haraldreingruber haraldreingruber changed the title Remove obsolete wasm-pack workaround CI: Remove obsolete wasm-pack workaround Apr 27, 2023
@cwfitzgerald
Copy link
Member

Sorry, missed this PR - superceded by #3754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants