fix(wgpu-core)!: use u32 indices for bind group layouts everywhere
#3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI indicates that |
|
I reran CI, that test keeps failing spuriously. |
ErichDonGubler
force-pushed
the
u32-bind-group-idx
branch
2 times, most recently
from
2778335 to
ee9381f
Compare
The short description of this bug/fix pair is that, for some reason, we accept `u32` bind indices in the `wgpu` and `wgpu-core` APIs, narrow to `u8`, and then use `usize` for bind group indices in `wgpu-core`'s internals. This artificially narrows the range of bind group indices, and seems incorrect. Fix this by using `u32`s all the way until we convert to `usize`s. AFAIK, no supported platforms for `wgpu` have a `usize` whose size is less than `u32`'s. For further details, see [Mozilla's Bugzilla] and [`wgpu`'s Matrix chat]. [Mozilla's Bugzilla]: https://bugzilla.mozilla.org/show_bug.cgi?id=1813705#c8 [`wgpu`'s Matrix chat]: https://matrix.to/#/!FZyQrssSlHEZqrYcOb:matrix.org/$0wv-PJgyTTZ7LHtEhzFmAouNYa4VMY0MzVzW0n5J394?via=matrix.org&via=mozilla.org&via=kde.org
ErichDonGubler
force-pushed
the
u32-bind-group-idx
branch
from
ee9381f to
532b401
Compare
|
I don't have rights to merge this. 😖 Can somebody do it for me, please? |
|
Yeet |
Wumpf
pushed a commit
to rerun-io/wgpu
that referenced
this pull request
May 14, 2023
cwfitzgerald
pushed a commit
that referenced
this pull request
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RunRUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
See
Description.Description
Describe what problem this is solving, and how it's solved.
See discussions in Mozilla's Bugzilla and
wgpu's Matrix chat.Testing
Explain how this change is tested.
cargo nextest run -- --workspaceWFM!