-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish examples to wgpu.rs on updates to trunk branch instead of gecko #3750
Conversation
CI failure is not related to this PR. The time crate updated since our last CI run and raised it's MSRV to 1.65 which broke the version of wasm-pack we are using since we compile for |
Opened a different PR that should fix the CI issue: #3754 |
078b6ab
to
3034e50
Compare
Rebased on the latest trunk to get the CI fix |
Looks like running the publish job locally is failing due to the updated time dependency too. Working on a fix. |
We can absolutely run the publishing job on latest stable. Only normal CI needs to check our MSRV |
Turns out this wasn't needed to test locally, just needed to use a runner image with rust installed.
Ah cool, I was thinking of using |
Fixes issue with building wasm-bindgen-cli.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Fixes #3684
Description
Switched the branch the publish action is using to
trunk
to allow the examples to be kept up to date as requested in #3684When testing I ran into the error
rustup: command not found
in theMain Install Rust WASM target
step, I fixed this by using dtolnay/rust-toolchain which is what the Bevy CI template uses for installing Rust in an action. Lmk if you would prefer I revert that.Testing
I tested this by installing https://github.com/nektos/act and running this command to mimic a github action runner using a minimal image that still contained the Rust stuff needed.
Note that it fails at uploading to github pages, which is expected since running locally you wouldn't have access to the secrets needed to do so.