Fix multiview rendering #3779
Merged
Fix multiview rendering #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cwfitzgerald This is a PR to do the fix for the thing in the issue |
teoxoy
previously requested changes
May 17, 2023
|
@teoxoy Made the change |
|
Do not merge this yet! I messed up the logic with the 2DTextureView to be inverted with the fix |
…yer count and TextureViewDimension when enabled
|
Fixed, feel free to do checks, resolve the issue and merge |
cwfitzgerald
approved these changes
May 19, 2023
teoxoy
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
fixes #3778
Description
WGPU Multiview works again by disabling some validation of TextureViewDimension and ResolvedArrayLayerCount
Testing
Running WGPU with a multiview enabled and trying it with multiple views.