Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump khronos-egl to v6 #3807

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented May 27, 2023

Nothing changed except the libloading dependency: https://github.com/timothee-haudebourg/khronos-egl/blob/5.0.0/CHANGELOG.md#500.

This is done in the same spirit as #3711 because khronos-egl v5 also depends on libloading v0.8, which in turn depends on windows-sys, which wgpu doesn't want to commit to yet: #3207.

Requires timothee-haudebourg/khronos-egl#23.
Replaces #3797.

@Snowiiii
Copy link

Snowiiii commented Jul 5, 2023

Why this taking so long...

@cwfitzgerald
Copy link
Member

We're waiting on timothee-haudebourg/khronos-egl#23

@cwfitzgerald cwfitzgerald added the PR: waiting for upstream Waiting for an upstream thing to change label Sep 14, 2023
@daxpedda daxpedda marked this pull request as ready for review October 5, 2023 13:34
@daxpedda daxpedda requested a review from a team as a code owner October 5, 2023 13:34
@daxpedda daxpedda changed the title Bump khronos-egl to v0.5 Bump khronos-egl to v6 Oct 5, 2023
@daxpedda
Copy link
Contributor Author

daxpedda commented Oct 5, 2023

Rebased on trunk.

This can be merged now with the khronos-egl v6 release. But actually v5 won't compile on Windows.
Should we ask khronos-egl to backport the fix (timothee-haudebourg/khronos-egl#23) to a v5.1 release?

@cwfitzgerald
Copy link
Member

I don't think so, we never shipped v5.

Cargo.toml Outdated Show resolved Hide resolved
@daxpedda
Copy link
Contributor Author

daxpedda commented Oct 5, 2023

I don't think so, we never shipped v5.

I meant because this PR does. Now that we just rely on v6 it's not an issue though.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@cwfitzgerald cwfitzgerald merged commit c85cbea into gfx-rs:trunk Oct 5, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: waiting for upstream Waiting for an upstream thing to change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants