Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RenderPass draw, draw_indexed, set_viewport and set_scissor_rect documentation #3860

Merged
merged 16 commits into from
Jun 17, 2023
Merged

Update RenderPass draw, draw_indexed, set_viewport and set_scissor_rect documentation #3860

merged 16 commits into from
Jun 17, 2023

Conversation

genusistimelord
Copy link
Contributor

This should hopefully make the documentation a bit better and more understandable for these functions. Please let me know what you like or dislike about this and anything I can fix or improve upon if i was wrong in some way.

@genusistimelord genusistimelord changed the title Update RenderPass draw, draw_indexed and set_scissor_rect documentation Update RenderPass draw, draw_indexed, set_viewport and set_scissor_rect documentation Jun 12, 2023
@genusistimelord
Copy link
Contributor Author

genusistimelord commented Jun 12, 2023

This does not fully fix #3852 but it is a good start at least.

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for contributing and getting the docs to a better place!

Really like the cross references!

I think though it's super important that the descriptions here are razor sharp and correct for all cases, so there's some more work needed here.
Generally I'd encourage to copy paste from the webgpu spec!

wgpu/src/lib.rs Outdated Show resolved Hide resolved
wgpu/src/lib.rs Outdated Show resolved Hide resolved
wgpu/src/lib.rs Outdated Show resolved Hide resolved
wgpu/src/lib.rs Outdated Show resolved Hide resolved
wgpu/src/lib.rs Outdated Show resolved Hide resolved
wgpu/src/lib.rs Outdated Show resolved Hide resolved
wgpu/src/lib.rs Outdated Show resolved Hide resolved
wgpu/src/lib.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf self-requested a review June 15, 2023 21:05
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff! Thanks again :)

@Wumpf Wumpf enabled auto-merge (squash) June 17, 2023 17:01
@Wumpf Wumpf merged commit 2ee2e1a into gfx-rs:trunk Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants