Fix ASTC feature selection in the webgl backend #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the Linux CI job failed for an unrelated reason. |
|
not great, but re-running fixed that ci failure 🙉 |
Wumpf
approved these changes
Jul 17, 2023
| @@ -77,6 +77,7 @@ Bottom level categories: | |||
| - Fix OpenGL/EGL backend not respecting non-sRGB texture formats in `SurfaceConfiguration`. by @liquidev in [#3817](https://github.com/gfx-rs/wgpu/pull/3817) | |||
| - Make write- and read-only marked buffers match non-readonly layouts. by @fornwall in [#3893](https://github.com/gfx-rs/wgpu/pull/3893) | |||
| - Fix leaking X11 connections. by @wez in [#3924](https://github.com/gfx-rs/wgpu/pull/3924) | |||
| - Fix ASTC feature selection in the webgl backend. by @expenses in [#3934](https://github.com/gfx-rs/wgpu/pull/3934) | |||
There was a problem hiding this comment.
this should go into a gl section, but looks like the bug fixes section is all over the place right now. can be cleaned up some point before the next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
grovesNL/glow#244
grovesNL/glow#245
Description
Currently we report both
TEXTURE_COMPRESSION_ASTCandTEXTURE_COMPRESSION_ASTC_HDRif the extension is implemented, even if only SDR or HDR is enabled.Testing
I've been using these changes on my own branch for a while.