Update max_bindings_per_bind_group from 640 to 1000 to reflect spec #3942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ErichDonGubler
approved these changes
Jul 19, 2023
No worries, I rebased this one on top of it to add the missing constant update in wgpu_types. |
cwfitzgerald
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.Connections
Spec: https://gpuweb.github.io/gpuweb/#dom-supported-limits-maxbindingsperbindgroup
Changed around mid April gpuweb/gpuweb#4050
Description
This PR update
max_bindings_per_bind_groupfrom 640 to 1000 to reflect changes that happened in the spec since it was introduced.Testing
This was caught by the WebGPU CTS in Firefox.