-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying minor GLES3 version #3998
Conversation
1e5253e
to
fcae97d
Compare
a129743
to
73dd7b0
Compare
Is there a better place to put it than |
Not really... this is where we need it. We probably should consider the ergonomics of InstanceDescriptor as this kind of thing likely will happen quite a bit. Let's leave it as is for now. |
Also allow this to be specified with env var and stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some concerns about how people will interpret and fill out the instance descriptor, but this is a larger question than this PR, so lets get this in.
Checklist
cargo clippy
.cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Fixes #3978
Description
Adds a
force_angle_gles31
flag towgpu::InstanceDescriptor
. This flag will force us to request a GLES3.1 context, which makes ANGLE provide as such on D3D11 (even though it's non-conformant).Testing
I ran a bunch of the samples with this forced on. There were some issues I found, but I didn't diagnose them too much:
boids
doesn't seem to present correctly, but in RenderDoc it does seem to work.water
doesn't render the water.