Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying minor GLES3 version #3998

Merged
merged 6 commits into from
Aug 16, 2023

Conversation

PJB3005
Copy link
Contributor

@PJB3005 PJB3005 commented Aug 1, 2023

Checklist

  • Run cargo clippy.
  • Run cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Fixes #3978

Description
Adds a force_angle_gles31 flag to wgpu::InstanceDescriptor. This flag will force us to request a GLES3.1 context, which makes ANGLE provide as such on D3D11 (even though it's non-conformant).

Testing
I ran a bunch of the samples with this forced on. There were some issues I found, but I didn't diagnose them too much:

  • boids doesn't seem to present correctly, but in RenderDoc it does seem to work.
  • water doesn't render the water.
  • sRGB when presenting is broken, so colors were messed up. Checking through renderdoc, it seems correct during internal rendering though.

@PJB3005 PJB3005 force-pushed the 23-08-01-force-gles31 branch 3 times, most recently from 1e5253e to fcae97d Compare August 1, 2023 21:47
@PJB3005 PJB3005 force-pushed the 23-08-01-force-gles31 branch from a129743 to 73dd7b0 Compare August 1, 2023 21:59
@PJB3005 PJB3005 requested a review from crowlKats as a code owner August 1, 2023 21:59
@PJB3005
Copy link
Contributor Author

PJB3005 commented Aug 1, 2023

Is there a better place to put it than InstanceDescriptor? The breaking change from this kinda sucks.

@cwfitzgerald
Copy link
Member

Not really... this is where we need it. We probably should consider the ergonomics of InstanceDescriptor as this kind of thing likely will happen quite a bit.

Let's leave it as is for now.

wgpu-types/src/lib.rs Outdated Show resolved Hide resolved
@PJB3005 PJB3005 changed the title Flag to force GLES31 on ANGLE Allow specifying minor GLES3 version Aug 4, 2023
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some concerns about how people will interpret and fill out the instance descriptor, but this is a larger question than this PR, so lets get this in.

@cwfitzgerald cwfitzgerald merged commit e973a06 into gfx-rs:trunk Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to force GLES-3.1 on Angle D3D11
2 participants