Prevent panic when submitting a destroyed buffer #4698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nical
force-pushed
the
submit-destroyed-buffer
branch
from
a6dd5db to
32a701f
Compare
teoxoy
approved these changes
Nov 16, 2023
nical
force-pushed
the
submit-destroyed-buffer
branch
from
32a701f to
02835f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.Connections
Another adjustment after #4657.
Description
The code in command buffer submission uses the "infallible" storage getter that panics if a texture or buffer has been destroyed, this PR adds the explicit check. Before #4657, the case of destroyed buffer was somewhat handled by checking whether the raw buffer was
None. it would not catch that a buffer had been scheduled for destruction but not actually destroyed yet. With this PR we can safely unwrap the option because get only returns the buffer if it is in a valid state.Testing
Covered by the CTS