Error on missing web_sys_unstable_apis #5104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5095
I thought about this some more and I think we can and should just give the user a helpful error when they are missing the unstable cfg.
With this we no longer need to take up prime documentation real estate with it.
I imagine resources like sotrh's learn wgpu will push users towards using
wgpu = { .. default-features = false, features = ["webgl"] }
to make it easy for users to run on the web and then this error will catch the user when they get that slightly wrong.Testing
I created a seperate crate that depends on wgpu and tested the following cases:
This compiles successfully:
This compiles successfully:
This fails to compile with the new error:
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.