Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MissingBufferUsageError now has an id prop #5203

Conversation

andristarr
Copy link
Contributor

Connections
#5066

Description
MissingBufferUsageError now has an id prop which is displayed when its raised

Testing

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@andristarr andristarr requested a review from a team as a code owner February 5, 2024 17:34
@andristarr andristarr force-pushed the Device--create_bind_group-error-shows-entry-which-produces-issue branch 2 times, most recently from d78007a to fd5a93a Compare February 5, 2024 19:20
@andristarr
Copy link
Contributor Author

Let me know if you would prefer another approach, i figured the buffer id would be sufficient

Copy link
Contributor

@nical nical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the review lag, This one fell under the radar. Just a small change and this is is good to go.

wgpu-core/src/validation.rs Outdated Show resolved Hide resolved
@andristarr andristarr force-pushed the Device--create_bind_group-error-shows-entry-which-produces-issue branch 2 times, most recently from 24bbf1d to abe2473 Compare February 13, 2024 18:08
@nical nical force-pushed the Device--create_bind_group-error-shows-entry-which-produces-issue branch from abe2473 to e6e952a Compare February 13, 2024 19:15
@nical nical enabled auto-merge (squash) February 13, 2024 19:16
@nical
Copy link
Contributor

nical commented Feb 13, 2024

Thanks!

@nical nical merged commit a7d7674 into gfx-rs:trunk Feb 14, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants