Store the device's queue via a weak ref instead of an ID #5230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
This is one of the internal uses of IDs instead of Arc/Weak references.
With this PR the Queue has an strong reference to the device and the device has a weak ref to the queue.
I think that to align with the WebGPU spec we should do the opposite (The device owns the queue). However that's more complicated to do this way because of the way the device and queue are destroyed currently (not impossible but more complicated).
This does not quite fix the test from #5211, but it turns the panic into a validation error in
create_command_encoder
.Checklist
cargo fmt
.cargo clippy
.cargo xtask test
to run tests.