Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output args for render_to_texture example #5338

Merged
merged 4 commits into from
Mar 9, 2024

Conversation

ratmice
Copy link
Contributor

@ratmice ratmice commented Mar 4, 2024

Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories

Description
The render_to_texture instructions specified render-to-texture as a --bin render-to-texture rather than wgpu-examples.
Since the example (e.g. render_to_texture) is now specified as the first argument, the output argument should now be the second one.

This also adds the default output to .gitignore.

Currently it will try to create a file named render_to_texture which when running under examples/src already exists and is a directory, which fails.

Testing
cargo run --bin wgpu-examples -- render_to_texture "test.png"

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@ratmice ratmice requested a review from a team as a code owner March 4, 2024 05:15
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch(es). Thanks for cleaning this up!

@Wumpf Wumpf enabled auto-merge (squash) March 9, 2024 09:48
@Wumpf Wumpf merged commit b731495 into gfx-rs:trunk Mar 9, 2024
27 checks passed
@ratmice ratmice deleted the rend_to_texture_out_arg branch March 9, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants