[wgpu-core] pass resources as Arcs when adding them to the registry #5499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nical
approved these changes
Apr 5, 2024
|
@nical wait, there are errors on wasm and Windows. Just fixed Windows and will push in a second, but I think we need to discuss the wasm one. |
|
FIxed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #5493
Linked to #5124
Description
Currently,
Registrytakes resources to insert by value. This is incompatible with dynamic-sized resources, which are the next step in #5124. This change instead takes resources already in theirArcs, and uses.get_mut()to modify them in place.Testing
No testing currently, but this is largely just a refactor. I'm not sure we need testing for it.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.