[spv-out] Move request_type_capabilities outside of LocalType lookup

CHANGELOG.md

@@ -168,7 +168,7 @@ Bottom level categories:
 #### Tests
 
 - Fix intermittent crashes on Linux in the `multithreaded_compute` test. By @jimblandy in [#5129](https://github.com/gfx-rs/wgpu/pull/5129).
-- Refactor tests to read feature flags by name instead of a hardcoded hexadecimal u64. By @rodolphito in [#5155](https://github.com/gfx-rs/wgpu/pull/5155).
+- Refactor tests to read feature flags by name instead of a hardcoded hexadecimal u64. By @atlv24 in [#5155](https://github.com/gfx-rs/wgpu/pull/5155).
 - Add test that verifies that we can drop the queue before using the device to create a command encoder. By @Davidster in [#5211](https://github.com/gfx-rs/wgpu/pull/5211)
 
 #### GLES

naga/src/back/spv/mod.rs

@@ -248,7 +248,7 @@ impl LocalImageType {
 /// this, by converting everything possible to a `LocalType` before inspecting
 /// it.
 ///
-/// ## `Localtype` equality and SPIR-V `OpType` uniqueness
+/// ## `LocalType` equality and SPIR-V `OpType` uniqueness
 ///
 /// The definition of `Eq` on `LocalType` is carefully chosen to help us follow
 /// certain SPIR-V rules. SPIR-V §2.8 requires some classes of `OpType...`

naga/src/back/spv/writer.rs

@@ -971,6 +971,12 @@ impl Writer {
     ) -> Result<Word, Error> {
         let ty = &arena[handle];
         let id = if let Some(local) = make_local(&ty.inner) {
+            // If it's a type that needs SPIR-V capabilities, request them now.
+            // This needs to happen regardless of the LocalType lookup succeeding,
+            // because some types which map to the same LocalType have different
+            // capability requirements. See https://github.com/gfx-rs/wgpu/issues/5569
+            self.request_type_capabilities(&ty.inner)?;
+
             // This type can be represented as a `LocalType`, so check if we've
             // already written an instruction for it. If not, do so now, with
             // `write_type_declaration_local`.
@@ -985,10 +991,6 @@ impl Writer {
 
                     self.write_type_declaration_local(id, local);
 
-                    // If it's a type that needs SPIR-V capabilities, request them now,
-                    // so write_type_declaration_local can stay infallible.
-                    self.request_type_capabilities(&ty.inner)?;
-
                     id
                 }
             }