Add a function to clear bindgroups from passes and bundles, with stub backend implementations. #5778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the spec allows null BindGroups to be passed to setBindGroup, we need a way to clear the BindGroup associated with an index. This patch implements that through a clear_bind_group function defined in various necessary places, and implements as much of it as possible, without getting into the wgpu-hal backend implementations, which are left as TODOs.
Connections
N/A
Testing
This code is not exercised, since all of our set_bind_group entry points require a BindGroup. The CTS contains tests that set null BindGroups.
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.