ensure that wgpu::Error is Sync
#5820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to wrap the error in `anyhow::Error` and `eyre::Report`, which require the inner error to be `Sync`.
ErichDonGubler
approved these changes
Jun 16, 2024
FL33TW00D
pushed a commit
to FL33TW00D/wgpu
that referenced
this pull request
Jun 20, 2024
* ensure that `wgpu::Error` is `Sync` This makes it possible to wrap the error in `anyhow::Error` and `eyre::Report`, which require the inner error to be `Sync`. * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
N/A
Description
This PR adds a
Syncbound to the boxedstd::error::Errorwithinwgpu::Error.This makes it possible to wrap the error in
anyhow::Errorandeyre::Report, which require the inner error to beSync.Testing
There is a static assertion.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.