[gl] reorder program_cache & context lock acquisition
#5870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using `program_cache.try_lock()` when creting pipelines which is covered by a guard gotten from `context.lock()`. For the `.try_lock()` to always succeed we need to make sure that the other lock acquisitions are also covered by a `context.lock()`. The `wgpu_examples::hello_compute::tests::multithreaded_compute` test has been failing intermittently in CI due to this.
ErichDonGubler
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Approving, but: Shouldn't @jimblandy's rules for lock ordering be updated with this, too? 🤔
|
The rules are for the locks in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using
program_cache.try_lock()when creting pipelines which is covered by a guard gotten fromcontext.lock(). For the.try_lock()to always succeed we need to make sure that the other lock acquisitions are also covered by acontext.lock().The
wgpu_examples::hello_compute::tests::multithreaded_computetest has been failing intermittently in CI due to this (recent example).Follow-up to #3380, relevant discussion: #3380 (comment).