Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few entry_point parameters #6031

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

nical
Copy link
Contributor

@nical nical commented Jul 24, 2024

Description

A few must have been missed in #5148 and somehow CI let it pass but caught it in #6030.

@nical nical requested a review from a team as a code owner July 24, 2024 11:59
@nical nical enabled auto-merge (squash) July 24, 2024 12:02
@ErichDonGubler
Copy link
Member

ErichDonGubler commented Jul 24, 2024

I can see how that happened/that PR became necessary. Those tests were added after the original base of the optional entry point PR. $OP-and-merging would not have caught that for either of them unless somebody had rebased and then checked CI after the other had merged. 😅

This is a point in favor of forcing PRs to be up-to-date before bringing into mainline history; CC @jimblandy, @cwfitzgerald.

@cwfitzgerald
Copy link
Member

Forcing PR's to be up to date is really annoying, but this is a good argument due merge trains, which we can enable.

@sagudev
Copy link
Contributor

sagudev commented Jul 24, 2024

$OP-and-merging would not have caught that for either of them unless somebody had rebased and then checked CI after the other had merged. 😅

This is a point in favor of forcing PRs to be up-to-date before bringing into mainline history

We use GitHub's merge queue in servo for this.

@ErichDonGubler
Copy link
Member

Oddly, MacOS CI timed out. Re-running.

@ErichDonGubler
Copy link
Member

Even if CI times out again, this PR is likely worth pushing to mainline anyway, since it fixes compilation failures. 😅

@teoxoy
Copy link
Member

teoxoy commented Jul 24, 2024

Oddly, MacOS CI timed out. Re-running.

Yeah, it started with #6021.

@teoxoy teoxoy disabled auto-merge July 24, 2024 12:31
@teoxoy teoxoy merged commit 7446790 into gfx-rs:trunk Jul 24, 2024
24 of 25 checks passed
@nical nical deleted the opt-entrypoints branch July 24, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants