Degenerification part 3/3: remove gfx_select, remove compute/render pass indirections
#6100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 10, 2024
Wumpf
force-pushed
the
degenerification-part3
branch
3 times, most recently
from
850188a
to
36941b0
Compare
Wumpf
force-pushed
the
degenerification-part3
branch
from
36941b0
to
9182770
Compare
cwfitzgerald
approved these changes
Aug 13, 2024
ErichDonGubler
force-pushed
the
degenerification-part3
branch
from
9182770
to
0c0641b
Compare
…s buffer operations
…PassTimestampWrites usable with DynQuerySet
collateral: ComputePass uses DynCommandEncoder during recording
bindgroup fixup
…ffects from there leading to boxing of almost all hal resources
gfx_select macros are empty husks now that are waiting to be removed
ErichDonGubler
force-pushed
the
degenerification-part3
branch
from
0c0641b
to
eb02613
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
wgpu-halDynDevice& friends #6098wgpu-core#6099gfx_select, remove compute/render pass indirections #6100Description
Finishes the series by ripping of various bandaids. Notably the dynamic indirections we had to use on compute & render passes go away again and
wgpucan hold the pass objects by value again.This also re-enables doc building on
wgpu-core!Please also have a look at the performance report here.
Note that slight changes have been made since these tests have been run, but the results should be representative.
If time permits, someone with convenient access should run Linux benchmarks as well.
Testing
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file