Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actual sample type to CreateBindGroupError::InvalidTextureSampleType output #6530

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Nov 12, 2024

Connections

Description

-

Testing

Tested that the output is more to my satisfaction. Is it to yours? 😀

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@ErichDonGubler ErichDonGubler added area: validation Issues related to validation, diagnostics, and error handling kind: diagnostics Error message should be better labels Nov 12, 2024
@ErichDonGubler ErichDonGubler self-assigned this Nov 12, 2024
@ErichDonGubler ErichDonGubler requested a review from a team as a code owner November 12, 2024 20:43
@ErichDonGubler ErichDonGubler force-pushed the better-InvalidTextureSampleType branch 2 times, most recently from 4916e23 to d7ebecd Compare November 12, 2024 22:00
@ErichDonGubler ErichDonGubler force-pushed the better-InvalidTextureSampleType branch from d7ebecd to 7cea521 Compare November 12, 2024 22:37
@ErichDonGubler ErichDonGubler merged commit b5986a9 into gfx-rs:trunk Nov 13, 2024
27 checks passed
@ErichDonGubler ErichDonGubler deleted the better-InvalidTextureSampleType branch November 13, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: validation Issues related to validation, diagnostics, and error handling kind: diagnostics Error message should be better
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants