Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [spv-in] atomics snapshot tests #6692

Merged

Conversation

schell
Copy link
Contributor

@schell schell commented Dec 9, 2024

Connections

Description
Moves the atomic operations support tests out of the SPIR-V frontend and into the standard snapshot tests.

Fixes #6292.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@schell schell mentioned this pull request Dec 9, 2024
@schell schell marked this pull request as ready for review December 9, 2024 22:19
@schell schell requested a review from a team as a code owner December 9, 2024 22:19
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there's a particular reason we're concerned that the SPIR-V front end might/needs to produce interesting output on particular backends, we generally only produce WGSL output.

The idea of the snapshots is that we do not actually convert every input file to every output language. Rather, we keep the "wings of the butterfly" separate:

  • We test all the front ends by converting all input languages to WGSL.
  • We test all the backends by converting WGSL inputs to every output language.

So unless there is special code in the backends that is only exercised by SPIR-V input (I don't think that's the case, but I'm not totally positive??), please only produce WGSL output for these input files.

@schell schell requested a review from jimblandy December 10, 2024 02:50
@schell
Copy link
Contributor Author

schell commented Dec 10, 2024

I've removed the extraneous snapshot output files 👍 .

@jimblandy jimblandy merged commit 8b93a71 into gfx-rs:trunk Dec 10, 2024
27 checks passed
@schell schell deleted the chore/spirv-front-atomics-use-standard-snapshots branch December 10, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[naga spv-in] Atomic tests should use the standard snapshot machinery
2 participants