Switch Binding Arrays on Metal to Argument Buffers #6751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
cw/argument-buffer-metal
branch
from
1f67c9f to
05236bc
Compare
cwfitzgerald
changed the title
cwfitzgerald
force-pushed
the
cw/argument-buffer-metal
branch
3 times, most recently
from
7be0e51 to
8986532
Compare
cwfitzgerald
force-pushed
the
cw/argument-buffer-metal
branch
3 times, most recently
from
cb8d1d7 to
793f047
Compare
cwfitzgerald
commented
Dec 23, 2024
| @@ -48,7 +48,7 @@ env: | |||
| CARGO_INCREMENTAL: false | |||
| CARGO_TERM_COLOR: always | |||
| WGPU_DX12_COMPILER: dxc | |||
| RUST_LOG: info | |||
| RUST_LOG: debug | |||
There was a problem hiding this comment.
I think this is a better setting anyway
cwfitzgerald
commented
Dec 23, 2024
Comment on lines
+70
to
+72
| { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Missed a feature check on this benchmark
cwfitzgerald
commented
Dec 23, 2024
| @@ -10,6 +9,8 @@ use super::conv; | |||
| use crate::auxil::map_naga_stage; | |||
| use crate::TlasInstance; | |||
|
|
|||
| use metal::foreign_types::ForeignType; | |||
cwfitzgerald
commented
Dec 23, 2024
| (entry, layout) | ||
| }); | ||
| for (entry, layout) in layout_and_entry_iter { | ||
| // Bindless path |
There was a problem hiding this comment.
The bindless path is entirely new, the bindful path is entirely the same.
cwfitzgerald
force-pushed
the
cw/argument-buffer-metal
branch
from
6857fc9 to
4ce012c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Closes #3334
Closes #3640
Depends on #6732
Commits cannot be merged separately, but can be reviewed separately