[spirv] Stop naga causing undefined behavior in rayQueryGet*Intersection
#6752
+906
−374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2024
…rt-undefined-behavior # Conflicts: # tests/tests/ray_tracing/as_build.rs
…andidate. This is because the requirements of spirv undefined behaviour require it like this.
3 tasks
…rt-undefined-behavior # Conflicts: # CHANGELOG.md
cwfitzgerald
requested changes
Dec 23, 2024
Comment on lines
+38
to
+50
| out = Intersection( | ||
| intersection.kind, | ||
| intersection.t, | ||
| intersection.instance_custom_index, | ||
| intersection.instance_id, | ||
| intersection.sbt_record_offset, | ||
| intersection.geometry_index, | ||
| intersection.primitive_index, | ||
| intersection.barycentrics, | ||
| u32(intersection.front_face), | ||
| intersection.world_to_object, | ||
| intersection.object_to_world, | ||
| ); |
There was a problem hiding this comment.
What values do these have if they are not valid to read? Similarly might it be useful to assert that the values are sane coming out of the api?
There was a problem hiding this comment.
The idea is these are always valid to read, it should just be zero.
There was a problem hiding this comment.
I'm not sure what happens on a mac though, it may still have undefined behavior.
There was a problem hiding this comment.
The way metal's API is designed seems to suggest that undefined behavior is unlikely (but I can't find anything in the specification that suggests this).
…to remove-rt-undefined-behavior
Vecvec
changed the title
rayQueryGet*IntersectionrayQueryGet*Intersection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
fixes #6731
Description
Naga previously unconditionally called operations that required the ray to hit something. This is undefined behavior according to the spirv raytracing spec. This caused seg-faults on lavapipe. This prevents that by separating the intersection getter into another function with conditional blocks.
Testing
added a test that previously failed (with a seg-fault) that now succeeds
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.