Implement SAMPLED_TEXTURE_ARRAY_NON_UNIFORM_INDEXING #715
+108
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
kvark
reviewed
Jun 12, 2020
bors bot
added a commit
that referenced
this pull request
Jun 12, 2020
715: Implement SAMPLED_TEXTURE_ARRAY_NON_UNIFORM_INDEXING r=kvark a=cwfitzgerald ## Connections Closes #483. Extends support for #106. ## Description This forwards the descriptor indexing features gfx-hal up to wgpu. Note this PR also changes the name of the `TEXTURE_BINDING_ARRAY` to `SAMPLED_TEXTURE_BINDING_ARRAY` to be more consistent with extensions. ## Testing Texture-array example was simply extended to use descriptor indexing. This works on all platforms that the feature is supported. (thanks @StarArawn) Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
cwfitzgerald
force-pushed
the
descriptor-indexing
branch
from
a49dd39
to
bfcc369
Compare
|
Canceled. |
|
bors r=kvark |
bors bot
added a commit
to gfx-rs/wgpu-rs
that referenced
this pull request
Jun 15, 2020
369: Implement SAMPLED_TEXTURE_ARRAY_NON_UNIFORM_INDEXING r=kvark a=cwfitzgerald This implements gfx-rs/wgpu#715 in wgpu-rs. I haven't changed the example, as I want to actually think up a better example to use and didn't want that to block this. It will change in the future however. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
369: Implement SAMPLED_TEXTURE_ARRAY_NON_UNIFORM_INDEXING r=kvark a=cwfitzgerald This implements gfx-rs#715 in wgpu-rs. I haven't changed the example, as I want to actually think up a better example to use and didn't want that to block this. It will change in the future however. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
715: Add pipeline statistics and timeline queries r=kvark a=cwfitzgerald Blocked on gfx-rs#1128. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Closes #483. Extends support for #106.
Description
This forwards the descriptor indexing features gfx-hal up to wgpu.
Note this PR also changes the name of the
TEXTURE_BINDING_ARRAYtoSAMPLED_TEXTURE_BINDING_ARRAYto be more consistent with extensions.Testing
Texture-array example was simply extended to use descriptor indexing. This works on all platforms that the feature is supported. (thanks @StarArawn)