Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GGUF file format specification #302
GGUF file format specification #302
Changes from 1 commit
d2fbcb2
23eda2e
b303293
2bcd348
576e306
44af6b8
24260bf
0133f2e
e9988f7
f4c4d6a
39da254
a6d1cc1
1d134ec
2a90bbf
3d4507e
39d6377
e36b4ca
d5cfb55
aa8d0ba
f3e7632
2fe03e5
2b65fba
b021b25
2da80c1
574b408
4ea9317
78faa7b
0da010d
ad95988
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be uint32 and an enum value instead of string. Executors may choose to generate human-readable descriptions based on that value. I can see that custom values in this can easily lead to confusions or leave this metadata as redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My reasoning for this is it's what Rust/Cargo does, and it seems to work quite well and leave the door open for future expansion / non-standard licenses (as is relatively common in ML). I could be convinced otherwise, but I don't see a strong reason to install that restriction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe clarify if the string should contain the license name / identifier, a link to the document or even the whole license document?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - I intended to refer to SPDX license expressions, but I didn't use that verbiage. Fixed.