gguf : remove special-case code for GGUFv1 #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This causes llama.cpp to just crash when trying to load a GGUFv1 model. We should check the version and show a message explaining why the model can't be loaded. |
danemadsen
added a commit
to Mobile-Artificial-Intelligence/llama.cpp
that referenced
this pull request
Nov 5, 2023
This reverts commit 2756c4f.
olexiyb
pushed a commit
to Sanctum-AI/llama.cpp
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortly after releasing GGUFv1 2-3 months ago, we switched to v2 using 64-bit int dimensions and quickly deprecated v1.
We added some special-case handling to support GGUFv1 and added TODOs to remove them after a certain period.
Assuming nobody is stuck at GGUFv1 at this point, so removing these special cases