llama : change yarn_ext_factor placeholder to -1 #3922
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been unable to reproduce any strange results from this code on gcc 12.3.0 or clang 16.0.6 - cparams.yarn_ext_factor is always correctly set to 0.0f for me.
However, with some compilers and system configurations and the
-Ofast
compiler option, the default of NaN apparently does not work. I was thinking that a good placeholder should be impossible to confuse for a valid value, but apparently the result of std::isnan cannot be relied upon.ref: #2268 (comment)