cuda : fix tensor size calculation for non-split buffer #5145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikawrakow
approved these changes
Jan 26, 2024
|
Not quite, the async memset was also not good, but it shouldn't cause issues. I wrote an explanation of the problem in the issue #5137 (comment). |
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jan 31, 2024
…ganov#5145)" This reverts commit 62fead3.
|
Hi @slaren, @Nexesenex reported that this specific commit caused a major speed regression with multigpu cuda. I'm wondering if there's any possibility that the change from |
|
The simple answer is no. |
jordankanter
pushed a commit
to jordankanter/llama.cpp
that referenced
this pull request
Feb 3, 2024
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Feb 5, 2024
…er (ggerganov#5145)"" This reverts commit 3d83ce9.
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5137