ci: add g++-10 and gcc-10 to the main-cuda #5580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains an attempt to work around an issue with CUDA 11.7.1 and gcc-11. The motivation for this change is that currently the following compilation error occurs when building the main-cuda image: ```console 219.4 ggml-cuda.cu(675): warning ggerganov#177-D: function "warp_reduce_max(half2)" was declared but never referenced 219.4 243.1 /usr/include/c++/11/type_traits:79:52: error: redefinition of 'constexpr const _Tp std::integral_constant<_Tp, __v>::value' 243.1 79 | template<typename _Tp, _Tp __v> 243.1 | ^ 243.1 /usr/include/c++/11/type_traits:67:29: note: 'constexpr const _Tp value' previously declared here 243.1 67 | static constexpr _Tp value = __v; 243.1 | ^~~~~ 243.9 make: *** [Makefile:447: ggml-cuda.o] Error 1 ``` Downgrading to gcc-10 and g++-10 seems to work around the issue. I'm not sure about the root cause of the issue, but will try to investigate further and see what proper fix might be. Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
This commit updates the full-cuda.Dockerfile and server-cuda.Dockerfile. Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
ggerganov
added a commit
that referenced
this pull request
Feb 19, 2024
|
Should be fixed with 68a6b98 |
jordankanter
pushed a commit
to jordankanter/llama.cpp
that referenced
this pull request
Mar 13, 2024
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains an attempt to work around an issue with CUDA 11.7.1 and gcc-11.
The motivation for this change is that currently the following compilation error occurs when building the main-cuda image:
Downgrading to gcc-10 and g++-10 seems to work around the issue. I'm not sure about the root cause of the issue, but will try to investigate further and see what proper fix might be.