-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kompute: implement op_getrows_f32 #6403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
op_getrows_f32 is required since ggerganov#6122 for the Vulkan w/ Kompute backend to be functional. As such, implement this op to make this backend functional again.
woachk
force-pushed
the
fix-kompute-getrows_f32
branch
from
March 31, 2024 06:25
2b4ac77
to
095647b
Compare
16 tasks
cebtenzzre
added a commit
to nomic-ai/llama.cpp
that referenced
this pull request
May 7, 2024
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
cebtenzzre
added a commit
to nomic-ai/llama.cpp
that referenced
this pull request
May 8, 2024
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
cebtenzzre
added a commit
to nomic-ai/llama.cpp
that referenced
this pull request
May 8, 2024
Co-authored-by: woachk <24752637+woachk@users.noreply.github.com> Signed-off-by: Jared Van Bortel <jared@nomic.ai>
cebtenzzre
added a commit
to nomic-ai/llama.cpp
that referenced
this pull request
May 9, 2024
Co-authored-by: woachk <24752637+woachk@users.noreply.github.com> Signed-off-by: Jared Van Bortel <jared@nomic.ai>
mofosyne
added
Review Complexity : Medium
Generally require more time to grok but manageable by beginner to medium expertise level
bugfix
fixes an issue or bug
labels
May 10, 2024
@cebtenzzre Are there any plans to merge this here? The kompute backend has not been functional for quite a while due to this, but I see that you merged it in the nomic repository. |
@ggerganov as discussed in the issue #6400 it happens today. |
ggerganov
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
fixes an issue or bug
Review Complexity : Medium
Generally require more time to grok but manageable by beginner to medium expertise level
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
op_getrows_f32 is required since #6122 for the Vulkan w/ Kompute backend to be functional.
As such, implement this op to make this backend functional again.
This addresses issue #6400