Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert.py: add python logging instead of print() #6511

Merged
merged 36 commits into from
May 3, 2024
Merged

convert.py: add python logging instead of print() #6511

merged 36 commits into from
May 3, 2024
+538 −484

Commits on Apr 30, 2024

  1. convert.py: add python logging instead of print()

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    573dcec View commit details
    Browse the repository at this point in the history

  2. convert.py: verbose flag takes priority over dump flag log suppression

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    88c1e2f View commit details
    Browse the repository at this point in the history

  3. convert.py: named instance logging

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e8be0c8 View commit details
    Browse the repository at this point in the history

  4. convert.py: use explicit logger id string

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    8008082 View commit details
    Browse the repository at this point in the history

  5. convert.py: convert extra print() to named logger

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e6b9d91 View commit details
    Browse the repository at this point in the history

  6. convert.py: sys.stderr.write --> logger.error

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3670e16 View commit details
    Browse the repository at this point in the history

  7. *.py: Convert all python scripts to use logging module

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f00454f View commit details
    Browse the repository at this point in the history

  8. requirements.txt: remove extra line

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    9ad587a View commit details
    Browse the repository at this point in the history

  9. flake8: update flake8 ignore and exclude to match ci settings

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c220e35 View commit details
    Browse the repository at this point in the history

  10. gh-actions: add flake8-no-print to flake8 lint step

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    8d855b1 View commit details
    Browse the repository at this point in the history

  11. pre-commit: add flake8-no-print to flake8 and also update pre-commit … 

    …version
    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    dd8b977 View commit details
    Browse the repository at this point in the history

  12. convert-hf-to-gguf.py: print() to logger conversion

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    44b058d View commit details
    Browse the repository at this point in the history

  13. *.py: logging basiconfig refactor to use conditional expression

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1cc38d8 View commit details
    Browse the repository at this point in the history

  14. *.py: removed commented out logging

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c2e5abd View commit details
    Browse the repository at this point in the history

  15. fixup! *.py: logging basiconfig refactor to use conditional expression

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    dc2bff4 View commit details
    Browse the repository at this point in the history

  16. constant.py: logger.error then exit should be a raise exception instead

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    cf38b4b View commit details
    Browse the repository at this point in the history

  17. *.py: Convert logger error and sys.exit() into a raise exception (for… 

    … atypical error)
    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    dc798d2 View commit details
    Browse the repository at this point in the history

  18. gguf-convert-endian.py: refactor convert_byteorder() to use tqdm prog… 

    …ressbar
    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ea44905 View commit details
    Browse the repository at this point in the history

  19. verify-checksum-model.py: This is the result of the program, it shoul… 

    …d be printed to stdout.
    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e0372a1 View commit details
    Browse the repository at this point in the history

  20. compare-llama-bench.py: add blank line for readability during missing… 

    … repo response
    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    510dea0 View commit details
    Browse the repository at this point in the history

  21. reader.py: read_gguf_file() use print() over logging

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    62da83a View commit details
    Browse the repository at this point in the history

  22. convert.py: warning goes to stderr and won't hurt the dump output

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1b1c2ed View commit details
    Browse the repository at this point in the history

  23. gguf-dump.py: dump_metadata() should print to stdout

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3a55ae4 View commit details
    Browse the repository at this point in the history

  24. convert-hf-to-gguf.py: print --> logger.debug or ValueError()

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    aefd749 View commit details
    Browse the repository at this point in the history

  25. verify-checksum-models.py: use print() for printing table

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1b7c800 View commit details
    Browse the repository at this point in the history

  26. *.py: refactor logging.basicConfig()

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b0b51e7 View commit details
    Browse the repository at this point in the history

  27. gguf-py/gguf/*.py: use __name__ as logger name 

    Since they will be imported and not run directly.
    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    fe1d7f6 View commit details
    Browse the repository at this point in the history

  28. python-lint.yml: use .flake8 file instead

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ad53853 View commit details
    Browse the repository at this point in the history

  29. constants.py: logger no longer required

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    58d5a5d View commit details
    Browse the repository at this point in the history

  30. convert-hf-to-gguf.py: add additional logging

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    2d2bc99 View commit details
    Browse the repository at this point in the history

  31. convert-hf-to-gguf.py: print() --> logger

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    5e5e74e View commit details
    Browse the repository at this point in the history

  32. *.py: fix flake8 warnings

    @mofosyne
    mofosyne committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    fcc5a5e View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. revert changes to convert-hf-to-gguf.py for get_name()

    @mofosyne
    mofosyne committed May 1, 2024
    Configuration menu
    Copy the full SHA
    6d42f3d View commit details
    Browse the repository at this point in the history

  2. convert-hf-to-gguf-update.py: use triple quoted f-string instead

    @mofosyne
    mofosyne committed May 1, 2024
    Configuration menu
    Copy the full SHA
    154ad12 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. *.py: accidentally corrected the wrong line

    @mofosyne
    mofosyne committed May 2, 2024
    Configuration menu
    Copy the full SHA
    08e2b77 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. *.py: add compilade warning suggestions and style fixes

    @mofosyne
    mofosyne committed May 3, 2024
    Configuration menu
    Copy the full SHA
    52d0567 View commit details
    Browse the repository at this point in the history