-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json
: $ref + object overhaul (https & recursive $refs, mix properties & allOf)
#8199
Open
ochafik
wants to merge
15
commits into
ggerganov:master
Choose a base branch
from
ochafik:json-refs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochafik
added
breaking change
Changes that break ABIs, APIs, file formats, or other forms of backwards compatibility.
Review Complexity : Medium
Generally require more time to grok but manageable by beginner to medium expertise level
labels
Jun 28, 2024
github-actions
bot
added
testing
Everything test related
examples
python
python script changes
server
labels
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Changes that break ABIs, APIs, file formats, or other forms of backwards compatibility.
examples
python
python script changes
Review Complexity : Medium
Generally require more time to grok but manageable by beginner to medium expertise level
server
testing
Everything test related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
$ref
&object
handling in JSON Schema -> GBNF converters:Support recursive
$ref
s (fixes Bug: JSON Schema - enum behind a $ref generates an object with unrestricted properties #8073)Resolve
https
$ref
s in C++ converter when built w/LLAMA_CURL=1
(caching result in RAM for now, may want to introduce HTTP caching semantics at some point)Allow mixing
properties
&anyOf
(simplified / unifiedobject
conversion code)Show example
Remove allowFetch options from Python & JS converters (kinda breaking change)
Align JavaScript conversion CLI (which was only used for tests) with the Python version (both in
examples
folder)# schema.json arg can be "-" for stdin, a URL or a file. node examples/json_schema_to_grammar.mjs schema.json python examples/json_schema_to_grammar.py schema.json
cc/ @HanClinto more JSON :-)