ci : fix docker build number and tag name #9638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, docker build (both from CI and locally via
docker build
) outputs build 0 when asking with--version
This is due to
.git
being included inside.dockerignore
, which make the directory not being copied into docker build context.The CI also have a problem where tag name becomes
:full-cuda--b1-1e43630
, while ideally it should be something like:full-cuda-b1234
In this PR
.git
from.dockerignore
:${{ matrix.config.tag }}
--> example::full-cuda
:${{ matrix.config.tag }}-b${BUILD_NUMBER}
--> example::full-cuda-b1234
Test
For testing purpose, I created a cloned repo: https://github.com/ngxson/llama.cpp-fix-ci/pkgs/container/llama.cpp-fix-ci/versions
For testing locally: