-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #470 - working 32-bit ARM #486
Conversation
Fixes NOTE not tested on Raspberry. Only on Armbian with OdroixXU4. Tested with neon fpu flag. Also had success with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a way to detect 32-bit ARM in the Makefile and choose the respective flags
That's what this PR does, the original code did not do this. Can you clarify in case I'm missing something? |
My Raspberry Pi 4 reports Does |
Ahhh, sounds like you have a 64-bit board but a 32-bit Operating System? Can you confirm?
No it does not, I do NOT have a 64-bit Pi 4, I have an armv7 board with no v8 extensions (see https://forums.raspberrypi.com/viewtopic.php?t=282791 for Pi4 self reporting, it reports as v7 in a 32-bit OS but allows access to v8 instructions). My board is ONLY 32-bit. New idea/proposal (assuming you have a really have pi4 board with 32-bit OS), in the 32-bit OS (v7) code block we add an additional conditional for detecting a raspberry pi board? Thoughts? Slightly off topic, you might find moving to a 64-bit OS gains you some extra performance else where for your board, then the makefile would drop into the next "if" check. |
Yes, it looks like I am using a 32-bit OS on my 64-bit RPi4. Thanks for clearing this up. |
What do you get for:
( If you get I don't have a Pi4 to check with 😿 This might also work for Pi 3b+ boards too. |
|
Hmmm, that completely surprised me. Sadly, I think your idea of a private change is the safest :-( I was really hoping we could automate this nicely. Alternative idea, mention pi 4 can use v8 extensions in a comment (e.g. the ones that worked for you) so its documented as a potential option? |
* issue ggerganov#470 - working 32-bit ARM * Update Makefile * Update Makefile --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
* issue ggerganov#470 - working 32-bit ARM * Update Makefile * Update Makefile --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
* issue ggerganov#470 - working 32-bit ARM * Update Makefile * Update Makefile --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
* issue ggerganov#470 - working 32-bit ARM * Update Makefile * Update Makefile --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
* issue ggerganov#470 - working 32-bit ARM * Update Makefile * Update Makefile --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
No description provided.