Update stream.cpp #501
Merged
Update stream.cpp #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#445 fix Language auto-detect "auto" flag does not work using the stream tool
|
This way, the stream example will keep on auto-detecting the language forever. Maybe it would be better after it auto-detects the spoken language to select it explicitly in order to avoid running the "auto-detect" code |
pannous
approved these changes
Apr 8, 2023
There was a problem hiding this comment.
Fantastic pull request exactly what I was looking for! why isn't it merged yet?
Detecting the language for every segment is perfect for our use case because the input language can change within the dialogue.
By the way the line that needs fixing has moved to line 150
|
Thank you, please merge. |
ggerganov
approved these changes
Apr 14, 2023
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
ggerganov#445 fix Language auto-detect "auto" flag does not work using the stream tool
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
ggerganov#445 fix Language auto-detect "auto" flag does not work using the stream tool
landtanin
pushed a commit
to landtanin/whisper.cpp
that referenced
this pull request
Dec 16, 2023
ggerganov#445 fix Language auto-detect "auto" flag does not work using the stream tool
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
ggerganov#445 fix Language auto-detect "auto" flag does not work using the stream tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#445 fix Language auto-detect "auto" flag does not work using the stream tool