Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cmake flag to disable F16C #628

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

a5huynh
Copy link
Contributor

@a5huynh a5huynh commented Mar 18, 2023

I'm running whisper in a virtualized environment for tests. The Makefile is able to build the binary just fine, but as a library I was running in an illegal instruction error.

Adding a flag to disable -mf16c did the trick.

@ggerganov ggerganov merged commit fc49c44 into ggerganov:master Mar 22, 2023
@a5huynh a5huynh deleted the add-f16c-cmake-option branch April 16, 2023 19:04
anandijain pushed a commit to anandijain/whisper.cpp that referenced this pull request Apr 28, 2023
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
landtanin pushed a commit to landtanin/whisper.cpp that referenced this pull request Dec 16, 2023
@thewh1teagle
Copy link
Contributor

thewh1teagle commented May 22, 2024

@ggerganov
Can we use -mf16c conditionally in runtime only if supported?

Maybe even use specific dll conditionally? (I use it from Rust)

Related: #2175

iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants