Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ggml : fix build on whisper.android (ARM_NEON) #764

Merged
merged 3 commits into from
Apr 15, 2023
Merged

ggml : fix build on whisper.android (ARM_NEON) #764

merged 3 commits into from
Apr 15, 2023

Conversation

jhen0409
Copy link
Contributor

  • Remove some inline handle to fix build on armeabi-v7a
  • Make own aligned_malloc function with posix_memalign
    • Not sure if it is a good idea. The original problem seems can be solved by upgrading minSdk to 28, but it may not be compatible with older versions of Android project
  • Add CI build for mobile platforms (objc, swiftui, android)

@jhen0409 jhen0409 changed the title Fix build on whisper.android (ARM_NEON) ggml : fix build on whisper.android (ARM_NEON) Apr 14, 2023
@ggerganov ggerganov merged commit ea1f8a5 into ggerganov:master Apr 15, 2023
@jhen0409 jhen0409 deleted the jhen-patch-1 branch April 15, 2023 20:04
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
@jhen0409
ggml, ci : fix build on whisper.android (ARM_NEON) + add CI (ggergano…
17d2a4f 
…v#764)

* ggml : fix undefined symbol by remove inline handle

* ggml : make own ggml_aligned_malloc function

* ci: add ios/android build
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
@jhen0409
ggml, ci : fix build on whisper.android (ARM_NEON) + add CI (ggergano…
8e942ff 
…v#764)

* ggml : fix undefined symbol by remove inline handle

* ggml : make own ggml_aligned_malloc function

* ci: add ios/android build
landtanin pushed a commit to landtanin/whisper.cpp that referenced this pull request Dec 16, 2023
@jhen0409
ggml, ci : fix build on whisper.android (ARM_NEON) + add CI (ggergano…
d304279 
…v#764)

* ggml : fix undefined symbol by remove inline handle

* ggml : make own ggml_aligned_malloc function

* ci: add ios/android build
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
@jhen0409 @iThalay
ggml, ci : fix build on whisper.android (ARM_NEON) + add CI (ggergano…
9a5cf7c 
…v#764)

* ggml : fix undefined symbol by remove inline handle

* ggml : make own ggml_aligned_malloc function

* ci: add ios/android build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhen0409 @ggerganov