Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.7.0 breaks vagrant-proxyconf plugin #249

Closed
tommoyer opened this issue Sep 11, 2015 · 2 comments
Closed

Release 0.7.0 breaks vagrant-proxyconf plugin #249

tommoyer opened this issue Sep 11, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@tommoyer
Copy link

When using 0.6.1 and vagrant-proxyconf (1.5.0 or 1.5.1) after the folder sync, the vagrant-proxyconf plugin is called to configure the proxy. With 0.7.0, vagrant-proxyconf is no longer called to configure the proxy.

@ggiamarchi
Copy link
Owner

Reading the vagrant-proxyconf source code, i guess the root cause is the same as #248. See https://github.com/tmatilai/vagrant-proxyconf/blob/v1.5.1/lib/vagrant-proxyconf/hook.rb#L11

@ggiamarchi ggiamarchi added the bug label Sep 18, 2015
@ggiamarchi ggiamarchi self-assigned this Sep 18, 2015
@ggiamarchi ggiamarchi added this to the 0.7.1 milestone Sep 18, 2015
@Sharpie
Copy link
Contributor

Sharpie commented Oct 27, 2015

This also breaks the vagrant-hostmanager plugin, which hooks into the default Provision action to update /etc/hosts across all running VMs.

What's the reason for using a custom ProvisionWrapper action? It appears to have the undocumented effect of substituting a @@ssh_ip@@ argument in shell provisioners.

I'd prefer the option of using the built-in Provision action so that other plugins work.

@ggiamarchi ggiamarchi modified the milestones: 0.7.1, 0.7.2 Feb 19, 2016
ggiamarchi added a commit that referenced this issue Apr 30, 2016
Sharpie pushed a commit to Sharpie/vagrant-openstack-provider that referenced this issue Jul 25, 2016
Sharpie pushed a commit to Sharpie/vagrant-openstack-provider that referenced this issue Jul 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants