Switch to Vagrant SyncedFolders #295
Conversation
Sharpie
force-pushed
the
use-standard-synced-folders
branch
from
0b04b15
to
e01ef2e
Compare
Vagrant 1.5 introduced a standard SyncedFolders middleware which can be re-used by providers to implement things such as rsync support. This patch uses Vagrant SyncedFolders as the default sync implementation instead of the legacy SyncFolder implementation inherited from the Rackspace project. The legacy implementation is retained for backwards compatibility and will be used if any of the following provider options is set: - rsync_includes - rsync_ignore_files - sync_method A deprecation warning will be printed.
Sharpie
force-pushed
the
use-standard-synced-folders
branch
from
e01ef2e
to
2fb940d
Compare
|
@ggiamarchi Thoughts on this change? The built-in synced folder implementation has many more features, and supports nice things like auto-installation of rsync. It also allows multiple synced folders to be set up, allows a single set of exclusions to be used across multiple providers, and allows for alternate sync methods such as NFS. |
|
@Sharpie No worries, I definitely agree moving to the built-in synced folder implementation is a thing to do ! Furthermore, there's a few issues and PR opened regarding synced folders on the OpenStack provider and i guess moving to the built-in implementation will resolve most of them. I'll try to take time soon to test and review. By the way, if someone else wants to help testing and feedback about about this one it would be really valuable. @craigtracey, @Aaronboyle, @brijs you could be interested in this one. |
|
@Sharpie Thanks for this great contribution and sorry for the long time to merge ! |
|
No worries! The FOSS projects I manage tend to have similar review lengths :) Thanks for the merge! |
…lders Switch to Vagrant SyncedFolders
Vagrant 1.5 introduced a standard SyncedFolders middleware which can be re-used
by providers to implement things such as rsync support. This patch uses Vagrant
SyncedFolders as the default sync implementation instead of the legacy
SyncFolder implementation inherited from the Rackspace project.
The legacy implementation is retained for backwards compatibility and will be
used if any of the following provider options is set:
A deprecation warning will be printed.